Fix deprecation warnings in Testcontainers wait strategies

See gh-12821
spring-projects · Apr 24, 2018 · 6c504a5 · 6c504a5
1 parent dc9254c
commit 6c504a5
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 12 deletions.
diff --git a/...src/main/java/org/springframework/boot/testsupport/testcontainers/CassandraContainer.java b/...src/main/java/org/springframework/boot/testsupport/testcontainers/CassandraContainer.java
@@ -24,7 +24,7 @@
 import org.rnorth.ducttape.TimeoutException;
 import org.rnorth.ducttape.unreliables.Unreliables;
 import org.testcontainers.containers.GenericContainer;
-import org.testcontainers.containers.wait.HostPortWaitStrategy;
+import org.testcontainers.containers.wait.strategy.HostPortWaitStrategy;
 
 /**
  * A {@link GenericContainer} for Cassandra.
@@ -37,14 +37,22 @@ public class CassandraContainer extends Container {
 	private static final int PORT = 9042;
 
 	public CassandraContainer() {
-		super("cassandra:3.11.1", PORT, (container) -> container
-				.waitingFor(new WaitStrategy()).withStartupAttempts(3));
+		super("cassandra:3.11.1", PORT,
+				(container) -> container
+						.waitingFor(new WaitStrategy(container.getMappedPort(PORT)))
+						.withStartupAttempts(3));
 	}
 
 	private static class WaitStrategy extends HostPortWaitStrategy {
 
+		private final int port;
+
+		private WaitStrategy(int port) {
+			this.port = port;
+		}
+
 		@Override
-		public void waitUntilReady(GenericContainer container) {
+		public void waitUntilReady() {
 			super.waitUntilReady();
 
 			try {
@@ -58,8 +66,7 @@ public void waitUntilReady(GenericContainer container) {
 
 		private Callable<Boolean> checkConnection() {
 			return () -> {
-				try (Cluster cluster = Cluster.builder()
-						.withPort(container.getMappedPort(PORT))
+				try (Cluster cluster = Cluster.builder().withPort(this.port)
 						.addContactPoint("localhost").build()) {
 					cluster.connect();
 					return true;

diff --git a/...ort/src/main/java/org/springframework/boot/testsupport/testcontainers/Neo4jContainer.java b/...ort/src/main/java/org/springframework/boot/testsupport/testcontainers/Neo4jContainer.java
@@ -24,7 +24,7 @@
 import org.rnorth.ducttape.TimeoutException;
 import org.rnorth.ducttape.unreliables.Unreliables;
 import org.testcontainers.containers.GenericContainer;
-import org.testcontainers.containers.wait.HostPortWaitStrategy;
+import org.testcontainers.containers.wait.strategy.HostPortWaitStrategy;
 
 /**
  * A {@link GenericContainer} for Neo4J.
@@ -34,19 +34,28 @@
  */
 public class Neo4jContainer extends Container {
 
+	private static final int PORT = 7687;
+
 	public Neo4jContainer() {
-		super("neo4j:3.3.1", 7687, (container) -> container.waitingFor(new WaitStrategy())
-				.withEnv("NEO4J_AUTH", "none"));
+		super("neo4j:3.3.1", PORT,
+				(container) -> container
+						.waitingFor(new WaitStrategy(container.getMappedPort(PORT)))
+						.withEnv("NEO4J_AUTH", "none"));
 	}
 
 	private static class WaitStrategy extends HostPortWaitStrategy {
 
+		private final int port;
+
+		private WaitStrategy(int port) {
+			this.port = port;
+		}
+
 		@Override
-		public void waitUntilReady(GenericContainer container) {
+		public void waitUntilReady() {
 			super.waitUntilReady();
 			Configuration configuration = new Configuration.Builder()
-					.uri("bolt://localhost:" + container.getMappedPort(7687))
-					.build();
+					.uri("bolt://localhost:" + this.port).build();
 			SessionFactory sessionFactory = new SessionFactory(configuration,
 					"org.springframework.boot.test.autoconfigure.data.neo4j");
 			try {