Skip to content

Commit

Permalink
Switch to the Apache Tomcat EL implementation by default
Browse files Browse the repository at this point in the history
Previously we used org.glassfish:jakarta.el as our default EL
implementation. Since adopting it we have learned that it can be
significantly slower than Apache Tomcat's EL implementation in some
scenarios. This commit switches to using
org.apache.tomcat.embed:tomcat-embed-el by default instead of the
Glassfish implementation.

Closes gh-24744
  • Loading branch information
wilkinsona committed Jan 15, 2021
1 parent e203399 commit 4b0d5c3
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ description = "Starter for using Jetty as the embedded servlet container. An alt
dependencies {
api("jakarta.servlet:jakarta.servlet-api")
api("jakarta.websocket:jakarta.websocket-api")
api("org.apache.tomcat.embed:tomcat-embed-el")
api("org.eclipse.jetty:jetty-servlets")
api("org.eclipse.jetty:jetty-webapp") {
exclude group: "javax.servlet", module: "javax.servlet-api"
Expand All @@ -21,5 +22,4 @@ dependencies {
exclude group: "javax.websocket", module: "javax.websocket-client-api"
exclude group: "org.eclipse.jetty", module: "jetty-jndi"
}
api("org.glassfish:jakarta.el")
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies {
api("org.apache.tomcat.embed:tomcat-embed-core") {
exclude group: "org.apache.tomcat", module: "tomcat-annotations-api"
}
api("org.glassfish:jakarta.el")
api("org.apache.tomcat.embed:tomcat-embed-el")
api("org.apache.tomcat.embed:tomcat-embed-websocket") {
exclude group: "org.apache.tomcat", module: "tomcat-annotations-api"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ dependencies {
exclude group: "org.jboss.spec.javax.servlet", module: "jboss-servlet-api_4.0_spec"
}
api("jakarta.servlet:jakarta.servlet-api")
api("org.glassfish:jakarta.el")
api("org.apache.tomcat.embed:tomcat-embed-el")
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ description = "Starter for using Java Bean Validation with Hibernate Validator"

dependencies {
api(project(":spring-boot-project:spring-boot-starters:spring-boot-starter"))
api("org.glassfish:jakarta.el")
api("org.apache.tomcat.embed:tomcat-embed-el")
api("org.hibernate.validator:hibernate-validator")
}

0 comments on commit 4b0d5c3

Please sign in to comment.