Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not ready for non-English users #7

Closed
paulvi opened this issue Jan 10, 2014 · 6 comments
Closed

Not ready for non-English users #7

paulvi opened this issue Jan 10, 2014 · 6 comments

Comments

@paulvi
Copy link

paulvi commented Jan 10, 2014

Thank you for great work on guides.

Most of guides build do not have source encoding set:

for maven

<properties>
    <!-- use UTF-8 for everything -->
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
</properties>

and for gradle

[ compileJava, compileTestJava ]*.options*.encoding = 'UTF-8'

http://www.romseysoftware.co.uk/2012/03/12/gradle-and-utf-8/

@dsyer
Copy link
Contributor

dsyer commented Mar 13, 2014

Actually all the guides that use the spring-boot-starter-parent already have this set. So this one for sure must have?

@paulvi
Copy link
Author

paulvi commented Mar 15, 2014

Well, I can't comment now. I have not tried spring-boot version since then.

szpak added a commit to szpak-forks/gs-spring-boot that referenced this issue Apr 22, 2014
@gregturn
Copy link
Contributor

gregturn commented Jun 3, 2014

@rwinch Do you know anyway to create something that would embed this encoding? For example, would a tweak to the spring-boot-gradle-plugin be possible to introduce this?
/cc @philwebb

@rwinch
Copy link

rwinch commented Jun 3, 2014

Yes you should be able to set the encoding in the Spring Boot Gradle plugin. I haven't really looked at the source of the Spring Boot plugin so I'm not sure exactly how it would be integrated (i.e. I don't know what assumptions the plugin makes which may make setting the property easier/harder). I'm guessing @philwebb would be able to do this fairly quickly since I think he wrote much of the plugin.

@gregturn
Copy link
Contributor

gregturn commented Jun 3, 2014

I would prefer something more comprehensive than editing each individual build.gradle file, you know?

@dsyer
Copy link
Contributor

dsyer commented Jan 5, 2015

It looks to me like that change was merged in 1.1.x somewhere, so this is now working in Maven and Gradle.

@dsyer dsyer closed this as completed Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants