Skip to content

Commit

Permalink
Update auto-configuration to use @configuration(proxyBeanMethods=fals…
Browse files Browse the repository at this point in the history
…e); fixes gh-236
  • Loading branch information
marcingrzejszczak committed Nov 13, 2019
1 parent f9f72fa commit 987a53a
Show file tree
Hide file tree
Showing 20 changed files with 22 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
* @author Spencer Gibb
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnZookeeperEnabled
@ConditionalOnProperty(value = "spring.cloud.zookeeper.config.enabled", matchIfMissing = true)
public class ZookeeperConfigAutoConfiguration {

@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnClass(RefreshEndpoint.class)
protected static class ZkRefreshConfiguration {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
* @author Spencer Gibb
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnZookeeperEnabled
@Import(ZookeeperAutoConfiguration.class)
public class ZookeeperConfigBootstrapConfiguration {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* @author Spencer Gibb
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnZookeeperEnabled
@EnableConfigurationProperties
public class ZookeeperAutoConfiguration {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
* @author Tom Gianos
* @since 2.0.1
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnZookeeperEnabled
@ConditionalOnClass(Endpoint.class)
@AutoConfigureAfter({ ZookeeperAutoConfiguration.class })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
* @author Dave Syer
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@EnableConfigurationProperties
@ConditionalOnZookeeperEnabled
@ConditionalOnBean(SpringClientFactory.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
* @author Tim Ysewyn
* @since 1.1.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnDiscoveryEnabled
@ConditionalOnZookeeperDiscoveryEnabled
@AutoConfigureBefore({ CommonsClientAutoConfiguration.class,
Expand All @@ -62,7 +62,7 @@ public ZookeeperServiceWatch zookeeperServiceWatch(
return new ZookeeperServiceWatch(curator, zookeeperDiscoveryProperties);
}

@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnClass({ Endpoint.class, HealthIndicator.class })
protected static class ZookeeperDiscoveryHealthConfig {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
* @author Tim Ysewyn
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnDiscoveryEnabled
@ConditionalOnBlockingDiscoveryEnabled
@ConditionalOnZookeeperDiscoveryEnabled
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
* @author Marcin Grzejszczak
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
public class ZookeeperRibbonClientConfiguration {

private static final Log log = LogFactory
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
*
* @author Dave Syer
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@EnableConfigurationProperties
@ConditionalOnClass({ ZookeeperDiscoveryProperties.class, CuratorFramework.class,
ConfigServerProperties.class })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
*/
@ConditionalOnClass(ConfigServicePropertySourceLocator.class)
@ConditionalOnProperty(value = "spring.cloud.config.discovery.enabled", matchIfMissing = false)
@Configuration
@Configuration(proxyBeanMethods = false)
@Import({ ZookeeperAutoConfiguration.class, ZookeeperDiscoveryClientConfiguration.class,
CuratorServiceDiscoveryAutoConfiguration.class,
ZookeeperDiscoveryAutoConfiguration.class })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
* @author Marcin Grzejszczak
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnDependenciesPassed
@ConditionalOnZookeeperEnabled
@ConditionalOnProperty(value = "spring.cloud.zookeeper.dependency.headers.enabled", matchIfMissing = true)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
* @author Marcin Grzejszczak
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnZookeeperEnabled
@ConditionalOnRibbonZookeeper
@ConditionalOnDependenciesPassed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
* @author Marcin Grzejszczak
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnZookeeperEnabled
@ConditionalOnRibbonZookeeper
@ConditionalOnDependenciesPassed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* @author Marcin Grzejszczak
* @since 1.0.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@EnableConfigurationProperties
@ConditionalOnZookeeperEnabled
@ConditionalOnDependenciesPassed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
* @author Tim Ysewyn
* @since 2.2.0
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnDiscoveryEnabled
@ConditionalOnReactiveDiscoveryEnabled
@ConditionalOnZookeeperDiscoveryEnabled
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
* @since 1.0.0
* @see ZookeeperDependencies
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@EnableConfigurationProperties
@ConditionalOnZookeeperEnabled
@ConditionalOnDependenciesPassed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
/**
* @author Spencer Gibb
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnMissingBean(type = "org.springframework.cloud.zookeeper.discovery.ZookeeperLifecycle")
@ConditionalOnZookeeperDiscoveryEnabled
@ConditionalOnProperty(value = "spring.cloud.service-registry.auto-registration.enabled", matchIfMissing = true)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
/**
* @author Spencer Gibb
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnZookeeperDiscoveryEnabled
@ConditionalOnProperty(value = "spring.cloud.service-registry.enabled", matchIfMissing = true)
@AutoConfigureBefore(ServiceRegistryAutoConfiguration.class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
/**
* @author Spencer Gibb
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@ConditionalOnDiscoveryEnabled
@ConditionalOnZookeeperDiscoveryEnabled
@AutoConfigureBefore({ ZookeeperDiscoveryAutoConfiguration.class,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
/**
* @author Spencer Gibb
*/
@Configuration
@Configuration(proxyBeanMethods = false)
@EnableAutoConfiguration
@RestController
@EnableFeignClients
Expand Down

0 comments on commit 987a53a

Please sign in to comment.