Connection pool shut down on "zuul.host.*" property change #3406
Labels
Comments
|
Closing in favor #3407 |
|
We are getting this error frequently. Is there a workaround for this for the time being? |
You can provide your own client by specifying the bean of type @Bean
public CloseableHttpClient httpClient() {
return HttpClientBuilder.create()
// configure max connections, timeouts etc.
.build();
}Check Updated. Another approach is to explicitly define bean of type @Bean
public SimpleHostRoutingFilter simpleHostRoutingFilter(ProxyRequestHelper helper,
ZuulProperties zuulProperties,
ApacheHttpClientConnectionManagerFactory connectionManagerFactory,
ApacheHttpClientFactory httpClientFactory) {
// Define the connection manager to be shared, preventing it from
// being shut down by the client
ApacheHttpClientFactory newHttpClientFactory = () -> httpClientFactory
.createBuilder().setConnectionManagerShared(true);
return new SimpleHostRoutingFilter(helper, zuulProperties,
connectionManagerFactory, newHttpClientFactory);
} |
|
Thanks, @denysivano, I 'll have a go on the mentioned workarounds. |
ryanjbaxter
pushed a commit
that referenced
this issue
Sep 3, 2019
* Re-create connection manager on "zuul.host.*" property change Fixes #3406 * Wrap connectionManager.shutdown() in try/catch block. Polishing
sabareeshkkanan
added a commit
to sabareeshkkanan/spring-cloud-netflix
that referenced
this issue
Dec 20, 2019
* Added symbolic link of index.adoc * Added symbolic link of index.adoc * set replication client filters in RefreshablePeerEurekaNodes (spring-cloud#3610) fixes spring-cloudgh-3554 * Update SNAPSHOT to 2.2.0.M2 * Going back to snapshots * Adding spring cloud circuitbreaker hystrix implementation * Separated circuitbreaker auto config to its own file * Initialize remoteRegionAppWhitelist with default value (spring-cloud#3634) * Moves non-netflix dependencies out of bom into root pom. fixes spring-cloudgh-3639 * Removes dependency management for okhttp3 * Moves okhttp3 dep mgmt back to bom * Re-create connection manager on "zuul.host.*" property change (spring-cloud#3407) * Re-create connection manager on "zuul.host.*" property change Fixes spring-cloud#3406 * Wrap connectionManager.shutdown() in try/catch block. Polishing * Removes okhttp3 again after added back in older branch. * Updating readme with note about building spring-cloud-netflix-hystrix-contract. Fixes spring-cloud#3497 * Fromatting * Upgrades eureka to 1.9.13 and excludes compactmap. fixes spring-cloudgh-3636 * Update SNAPSHOT to 2.1.3.RELEASE * Going back to snapshots * Bumping versions to 2.1.4.BUILD-SNAPSHOT after release * Add Spring Cloud LoadBalancer starter to Eureka starters. Fixes spring-cloudgh-3646. (spring-cloud#3647) * Update docs. (spring-cloud#3650) * ConditionalOnMissingBean on formBodyWrapperFilter, debugFilter… (spring-cloud#3609) * Bumping versions * Remove spring.provides. * removes useless comments * Fix RestTemplateEurekaHttpClient status update endpoint. Fixes spring-cloud#3571 (spring-cloud#3657) * polish * Updates health check handler to use new StatusAggregator * Gh 3409 turbine stream test (spring-cloud#3665) * Add stream-test-support. * Fix condition. * Remove outdated workaround. * Bumping versions * Optimize code of eureka (spring-cloud#3660) * Optimize code of eureka * Merge newest code * fix checkstyle bug * Gh 3464 upgrade scc new (spring-cloud#3667) * Upgrade Spring Cloud Contract version to 2.1.3.RELEASE. * Gh 3409 turbine stream test (spring-cloud#3665) * Add stream-test-support. * Fix condition. * Remove outdated workaround. (cherry picked from commit 24f5e0b) * Updates to use "components" rather than "details" See spring-projects/spring-boot#17929 * Applying spring-cloud#3407 to the 2.1.x branch * Added support for reactive service discovery * Update SNAPSHOT to 2.2.0.M3 * Going back to snapshots * Update SNAPSHOT to 2.2.0.RC1 * Going back to snapshots * removing resource class from circle config * Add property to disable spring cloud circuit breaker for hystrix * Fix command key configuration. Use id as command key and class as group key. * Adding configuration metadata for spring cloud circuitbreaker * Bumping versions * Fix some dependencies that show up in the wrong scope Apparently you can build on the command line but Eclipse is fussy now and wouldn't compile these projects without explicit dependencies. * Also add build helper config for contract tests * Added maven flatten plugin * Bumping versions * Update SNAPSHOT to 2.2.0.RC2 * Going back to snapshots * Update configuration to use proxyBeanMethods=false. Fixes spring-cloud#3677 * Create security.md * Update issue templates * Bumping versions * Bumping versions * Update SNAPSHOT to 2.2.0.RELEASE * Going back to snapshots * Bumping versions to 2.2.1.BUILD-SNAPSHOT after release * Bumping versions * Fix typo: clas -> class (spring-cloud#3710) * removes .flattened-pom.xml * ignores .flattened-pom.xml * Gh 3718 add zoned loadbalancer instrumentation (spring-cloud#3720) * Add instrumentation for zoned LoadBalancer. * Add documentation. * Fix after review. * Fix after review. * Update SNAPSHOT to 2.2.1.RELEASE * Going back to snapshots * Bumping versions to 2.2.2.BUILD-SNAPSHOT after release Co-authored-by: Marcin Grzejszczak <marcin@grzejszczak.pl> Co-authored-by: Yuxin Bai <LittleBaiBai@users.noreply.github.com> Co-authored-by: Spencer Gibb <spencer@gibb.tech> Co-authored-by: Spring Buildmaster <buildmaster@springframework.org> Co-authored-by: Ryan Baxter <rbaxter@pivotal.io> Co-authored-by: emilnkrastev <emilnkrastev@gmail.com> Co-authored-by: Denys Ivano <denys.ivano@gmail.com> Co-authored-by: Olga Maciaszek-Sharma <olga.maciaszek@gmail.com> Co-authored-by: Rafał Żukowski <rzukow@gmail.com> Co-authored-by: OLPMO <OLPMO@users.noreply.github.com> Co-authored-by: Tim Ysewyn <Tim.Ysewyn@me.com> Co-authored-by: Dave Syer <david_syer@hotmail.com> Co-authored-by: Deepika Mohan <deepikadevidm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem:
When using Spring Boot + Spring Cloud Netflix Zuul and changing any
zuul.host.*property dynamically, an exception occurred on any subsequent forwarding request:Cause:
When changing
zuul.host.*property,SimpleHostRoutingFilterre-creates ApacheHttpClient, closing the previous one.By default, when
HttpClientis being closed, it also closes the underlyingHttpClientConnectionManager, except explicitly specifying.setConnectionManagerShared(true)onHttpClientBuilderinstance during client creation.SimpleHostRoutingFilteruses the single instance ofHttpClientConnectionManagerfor creating newHttpClients. On property change, it closesHttpClientand the underlyingHttpClientConnectionManager, which leads to an exception described above.Code example:
Here is the simple app for reproducing this problem: connection-pool-shut-down.zip
It starts on port 8080, forwards requests
/api/actuator/**tohttp://localhost:8080/actuator/**and provides endpoint/changefor changingzuul.host.maxConnectionsproperty.Steps to reproduce:
mvn clean verify spring-boot:runcurl http://localhost:8080/api/actuator/healthcurl http://localhost:8080/changecurl http://localhost:8080/api/actuator/healthThe text was updated successfully, but these errors were encountered: