Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log statement #1620

Merged
merged 143 commits into from
Apr 2, 2024
Merged

Add log statement #1620

merged 143 commits into from
Apr 2, 2024

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Apr 1, 2024

No description provided.

wind57 and others added 30 commits December 4, 2021 07:59
@@ -109,6 +109,9 @@ private V1Pod internalGetPod() {
}
catch (Throwable t) {
if (failFast) {
if (t instanceof ApiException apiException) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this came out after I triaged an issue over the weekend. It was not clear at all what is going on, meaning without this log, the real cause is not visible in logs

@wind57 wind57 marked this pull request as ready for review April 2, 2024 11:30
@wind57
Copy link
Contributor Author

wind57 commented Apr 2, 2024

@ryanjbaxter this one is ready too. I've tagged you in two PRs, and I have a few more in motion... whenever you get a chance. thank you

@ryanjbaxter ryanjbaxter added this to the 3.1.2 milestone Apr 2, 2024
@ryanjbaxter ryanjbaxter merged commit 4194a22 into spring-cloud:main Apr 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants