-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate constructor that uses namespace #1285
Merged
ryanjbaxter
merged 37 commits into
spring-cloud:main
from
wind57:deprecate-constructor-that-uses-namespace
Apr 7, 2023
Merged
Changes from 36 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
032014e
test
wind57 c3d0ad2
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 10889fd
fix @Nested tests not running
wind57 8f0375a
merged main
wind57 96ebf42
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 db8403e
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 90a5345
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 b041c00
trigger again
wind57 9580444
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 a34ac47
Add renovate.json
renovate[bot] 6613f78
Merge branch 'spring-cloud:main' into main
wind57 1b3eae9
Merge pull request #1 from wind57/renovate/configure
wind57 4275382
Merge branch 'spring-cloud:main' into main
wind57 618f25a
Delete renovate.json
wind57 100a9cd
Delete delme.sh
wind57 4b9056b
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 315a85b
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 ed3c264
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 446d630
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 6821a28
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 9e95a8a
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 02840b1
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 7e31d65
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 926f4d7
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 344e1d4
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 e91ac12
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 ba6e088
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 49025e8
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 a647bb3
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 16b09ab
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 c8d8a72
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 30436b5
fix
wind57 8c1a4ee
checkstyle
wind57 591f340
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 c331bd0
Merge branch 'main' of https://github.com/spring-cloud/spring-cloud-k…
wind57 f4755d5
Merge branch 'main' into deprecate-constructor-that-uses-namespace
wind57 248c30a
review comments fixes
wind57 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldnt be creating 2 bean instances, we can remove the
@Bean
annotation aboveThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's
@ConditionalOnMissingBean
on both of them, so only one will be created. We don't care which one will be created at this point in time, because they do the same thing in their constructors.Later, in the next major release, I will have a PR that drops all of these deprecations.
Btw, the same situation exists in
KubernetesInformerDiscoveryClientAutoConfiguration
(the non-reactive auto-configuration).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even better now that I think about your suggestion is to remove the
@Bean
in both reactive and non-reactive auto-configurations. This is one nice piece of advice, thank you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly