Refactor ConfigurationChangeDetector to simplify conditionals #643
Labels
Milestone
Comments
krisiye
added a commit
to krisiye/spring-cloud-kubernetes
that referenced
this issue
Sep 26, 2020
…ge detectors each for reload detection mode event/polling. Fixes spring-cloud#643
ryanjbaxter
pushed a commit
that referenced
this issue
Oct 1, 2020
…643 (#644) * Refactor configuration change detector into configMap and Secret change detectors each for reload detection mode event/polling. Fixes #643 * Add additional tests * Refactor spring-cloud-kubernetes-configuration-watcher to decouple configMap and Secrets for HTTP and Bus implementations * fix logger * fix checkstyle errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of #635 we fixed ConfigurationChangeDetector to honor conditionals where either config or secret could be enabled/disabled or vice-versa. This adds a level of complexity and null checking that could be improved upon. Refactor so that we register a ConfigurationChangeDetector each for config/secret and per mode (Polling/Event). Simplify code and more readable.
The text was updated successfully, but these errors were encountered: