Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to clarify in the docs that request size filter acts on Content-Length header #3085

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Proposal to clarify in the docs that request size filter acts on Content-Length header #3085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0bb233
Update RequestSizeGatewayFilterFactory.java
DressedUpZebra Oct 1, 2023
4ee5db4
Update GatewayFilterSpec.java
DressedUpZebra Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ava/org/springframework/cloud/gateway/filter/factory/RequestSizeGatewayFilterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
import static org.springframework.cloud.gateway.support.GatewayToStringStyler.filterToStringCreator;

/**
* This filter blocks the request, if the request size is more than the permissible size.
* This filter blocks the request if the size in Content-Length header value is more than the permissible size.
* Has no effect if Content-Length header is missing.
* The default request size is 5 MB.
*
* @author Arpan
Expand Down
4 changes: 2 additions & 2 deletions ...rver/src/main/java/org/springframework/cloud/gateway/route/builder/GatewayFilterSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ protected Optional<URI> determineRequestUri(ServerWebExchange exchange, Object c
}

/**
* A filter that sets the maximum permissible size of a Request.
* A filter that sets the maximum permissible size of a Content-Length header value in the Request.
* @param size the maximum size of a request
* @return a {@link GatewayFilterSpec} that can be used to apply additional filters
*/
Expand All @@ -814,7 +814,7 @@ public GatewayFilterSpec setRequestSize(Long size) {
}

/**
* A filter that sets the maximum permissible size of a Request.
* A filter that sets the maximum permissible size of a Content-Length header value in the Request.
* @param size the maximum size of a request
* @return a {@link GatewayFilterSpec} that can be used to apply additional filters
*/
Expand Down