Add relaxed names to nodeSelector property resolution. #464
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
approved these changes
Jul 9, 2024
|
|
||
| boolean hasGlobalNodeSelector = StringUtils.hasText(properties.getNodeSelector()); | ||
| String nodeSelectorDeploymentProperty = deploymentProperties.getOrDefault(KubernetesDeployerProperties.KUBERNETES_DEPLOYMENT_NODE_SELECTOR, ""); | ||
| for (String name : RelaxedNames.forCamelCase(KubernetesDeployerProperties.KUBERNETES_DEPLOYMENT_NODE_SELECTOR)) { |
There was a problem hiding this comment.
This solution will not work because KUBERNETES_DEPLOYMENT_NODE_SELECTOR does not follow the KubernetesDeployment prefix format of spring.cloud.deployer.kubernetes. It is currently spring.cloud.deployer.kubernetes.deployment.
The addition of the RelaxedNames does support when users use camel case instead of kabob case, but with the correct prefix.
cppwfs
requested changes
Jul 9, 2024
|
Closing this PR in light of the PR 466 issued by @corneil |
|
Whoops closed the wrong PR ! |
cppwfs
changed the title
…DE_SELECTOR name.
cppwfs
approved these changes
Jul 9, 2024
corneil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462