Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated spring-framework to 5.3.33 and okhttp to 4.12.0 #447

Merged
merged 1 commit into from
May 3, 2024
Merged

Updated spring-framework to 5.3.33 and okhttp to 4.12.0 #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<commons-io.version>2.7</commons-io.version>
<kubernetes-fabric8-client.version>5.12.4</kubernetes-fabric8-client.version>
<spring-boot.version>2.7.18</spring-boot.version>
<spring-framework.version>5.3.32</spring-framework.version>
<spring-framework.version>5.3.33</spring-framework.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<logback.version>1.2.13</logback.version>
Expand Down
2 changes: 1 addition & 1 deletion spring-cloud-deployer-cloudfoundry/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<cloudfoundry-java-lib.version>4.16.0.RELEASE</cloudfoundry-java-lib.version>
<pivotal-cf-client-reactor.version>2.2.0.RELEASE</pivotal-cf-client-reactor.version>
<commons-compress.version>1.26.0</commons-compress.version>
<okhttp.version>3.14.9</okhttp.version>
<okhttp.version>4.12.0</okhttp.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrt "Should we bump major from 3.x to 4.x?"...

On the surface, the 4.x changelog looks scary. However, the reality is that they have spent a lot of time and energy (their words) on keeping 4.x compatible w/ 3.x (details.

I am much less concerned of the risk at this point. However, what is the reward for doing this? CVE patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest 3.x contains vulnerabilities.

</properties>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion spring-cloud-deployer-kubernetes/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<java-semver.version>0.9.0</java-semver.version>
<maven.compiler.plugin.version>3.8.0</maven.compiler.plugin.version>
<powermock.version>2.0.2</powermock.version>
<okhttp.version>3.14.9</okhttp.version>
<okhttp.version>4.12.0</okhttp.version>
<fabric8-kubernetes-client.version>5.12.4</fabric8-kubernetes-client.version>
</properties>

Expand Down
Loading