Added k8s requests and limits #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
reviewed
Mar 25, 2024
...va/org/springframework/cloud/deployer/spi/kubernetes/RunAbstractKubernetesDeployerTests.java
Show resolved
Hide resolved
onobc
reviewed
Mar 26, 2024
...ain/java/org/springframework/cloud/deployer/spi/kubernetes/DeploymentPropertiesResolver.java
Show resolved
Hide resolved
onobc
reviewed
Mar 26, 2024
...ain/java/org/springframework/cloud/deployer/spi/kubernetes/DeploymentPropertiesResolver.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Mar 26, 2024
...ain/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesDeployerProperties.java
Show resolved
Hide resolved
onobc
requested changes
Mar 26, 2024
There was a problem hiding this comment.
@corneil - thanks for adding this. A nit, a question, and a suggested improvement but other than that LGTM.
corneil
force-pushed
the
corneil/added-k8s-limits-requests
branch
from
7deb98c to
7ac1c83
Compare
…nd hugepages-1Gi Fixes spring-cloud#441
corneil
force-pushed
the
corneil/added-k8s-limits-requests
branch
from
7ac1c83 to
d7c4b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added k8s requests and limits for ephemeral-storage , hugepages-2Mi and hugepages-1Gi
Fixes #441