Skip to content
This repository has been archived by the owner on Apr 20, 2022. It is now read-only.

Refactor Concourse folder structure #91

Merged
merged 1 commit into from
Sep 30, 2017

Conversation

malston
Copy link
Contributor

@malston malston commented Sep 25, 2017

This folder structure is makes it a little easier to tell which shell scripts are tasks and which are shared. I find it a little easier to navigate in an editor as well. Thoughts?

@marcingrzejszczak
Copy link
Contributor

@nebhale @philwebb @mbhave - you are Concourse experts - what do you think about this change? Does the pipeline look more Concourse like? As a reminder: one of the issues with Spring Cloud Pipelines and Concourse was the fact that I initially wrote it in the way I work with Jenkins. The idea of this PR is to refactor the current Concourse structure to better reflect the way developers work with it.

@mbhave
Copy link

mbhave commented Sep 25, 2017

@marcingrzejszczak I prefer having a scripts folder and a tasks folder to separate the yml and shell scripts. Somewhat similar to what concourse itself does for its CI here but with the .yml files put in a tasks folder instead.

@philwebb
Copy link

@marcingrzejszczak
Copy link
Contributor

@malston says that some of the Labs teams are working like the way he presented. I guess it's not a gigantic difference between the 2 approaches, isn't it?

@marcingrzejszczak marcingrzejszczak added this to the 1.0.0.M7 milestone Sep 30, 2017
@marcingrzejszczak marcingrzejszczak merged commit c764db5 into spring-attic:master Sep 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

4 participants