This repository has been archived by the owner on Apr 20, 2022. It is now read-only.
Improve Concourse #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the pipeline definition to use the proper substitution syntax for Concourse 3.2 and later.
This change updates the pipeline to make use of YAML references. This allows common blocks of code (like parameter groups) to be defined once and shared between jobs.
This change modifies the format a bit to make it consistent across the entire file. This mostly has to do with the indention of YAML arrays.
The change improves the generate-version task. It does this by using a more descriptive output name, using a local clone as recommended by the Concourse team, and only configuring the local git repository.
marcingrzejszczak
approved these changes
Jul 28, 2017
| APP_MEMORY_LIMIT: {{app-memory-limit}} | ||
| BUILD_OPTIONS: {{build-options}} | ||
| PAAS_TYPE: {{paas-type}} | ||
| common-params: &common-params |
There was a problem hiding this comment.
I thought you'd like that 😉
| - name: repo | ||
| type: git | ||
| source: | ||
| uri: ((app-url)) |
There was a problem hiding this comment.
is it mandatory to use (( )) syntax, or does the {{ }} syntax still apply?
There was a problem hiding this comment.
{{ }} is now deprecated since curly braces are actually YAML syntax keywords (YAML flow syntax specifically source: {uri: https://...}). They never should have used it and are now in alignment with most other YAML templating systems.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are a step-by-step improvement on the existing Concourse scripting implementation. Some of the changes are significant some are just idiomatic formatting changes. At this point there is no change to how the pipeline itself works, just improvements to the Concourse configuration.