Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-1098] Added preference to toggle HTTP caching for Storefrront #10688

Merged
merged 7 commits into from
Jan 18, 2021
Merged

[SD-1098] Added preference to toggle HTTP caching for Storefrront #10688

merged 7 commits into from
Jan 18, 2021

Conversation

KacperMekarski
Copy link
Contributor

damianlegawiec and others added 2 commits September 19, 2020 16:20
@damianlegawiec
Added preference to toggle HTTP caching for Storefrront
d75e6e3 
`Spree::Frontend::Config[:http_cache_enabled]` is now used to determine if we should cache Home page, Product page, Product list & Taxon page. By default, it's enabled. For flexibility,  you can now disable this altogether. Useful for private/internal websites.
SD-1098 merge master branch
5168983
@squash-labs
Copy link

squash-labs bot commented Jan 18, 2021

Manage this branch in Squash

Test this branch here: https://featureconditional-caching-q5xa2.squash.io

@KacperMekarski KacperMekarski changed the title Feature/conditional caching Added preference to toggle HTTP caching for Storefrront Jan 18, 2021
@KacperMekarski KacperMekarski changed the title Added preference to toggle HTTP caching for Storefrront [SD-1098] Added preference to toggle HTTP caching for Storefrront Jan 18, 2021
damianlegawiec
damianlegawiec reviewed Jan 18, 2021
View reviewed changes
Copy link
Member

@damianlegawiec damianlegawiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KacperMekarski let's also add some basic test if this on/off toggle works :)

frontend/app/controllers/spree/home_controller.rb Outdated Show resolved Hide resolved
@KacperMekarski KacperMekarski marked this pull request as draft January 18, 2021 12:47
@KacperMekarski KacperMekarski marked this pull request as ready for review January 18, 2021 14:58
KacperMekarski and others added 2 commits January 18, 2021 16:41
@KacperMekarski @damianlegawiec
Update frontend/app/controllers/spree/products_controller.rb
b672bd9 
Co-authored-by: Damian Legawiec <damian@sparksolutions.co>
@KacperMekarski @damianlegawiec
Update frontend/app/controllers/spree/products_controller.rb
f74d610 
Co-authored-by: Damian Legawiec <damian@sparksolutions.co>
@damianlegawiec damianlegawiec merged commit 74b66b0 into master Jan 18, 2021
@damianlegawiec damianlegawiec deleted the feature/conditional-caching branch February 4, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianlegawiec damianlegawiec damianlegawiec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KacperMekarski @damianlegawiec