Improve Parse.Ref #179
Merged
Improve Parse.Ref #179
+120
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, Marcin 👍 Seems like a bug/design limitation of memos, though not having been in the codebase for a while, I can't immediately spot it... happy to push forward with the fix as-is, but if you (or anyone following along) can spot the underlying issue, it'd be great to be able to address it at a lower level 🤔 |
|
I will try to create additional unit tests later today to check if the fix doesn't break anything. |
…tains info about left recursion
|
@nblumhardt Please find my latest changes. I think the latest commit contains proper solution to the problem. Best regards, |
|
Awesome! Thank you, Marcin 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
Parse.Refis having some problems when used heavily together withOr.Please take a look at my fix, a unit test.
There is also workaround but I would prefer not to use it.
The workaround:
Parse.Ref(() => parser)toParse.Ref(() => parser.Named("unique_name"))Best regards,
Marcin