Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid garbage collection for requests.Session #1189

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

dieser-niko
Copy link
Member

Closes #621

@zlonghofer if you want, you can also review this little PR
@stephanebruckert can you help me figure out how I can fix the linting issue?

@stephanebruckert
Copy link
Member

@dieser-niko try the last step from https://github.com/spotipy-dev/spotipy/blob/master/CONTRIBUTING.md#lint

isort .

Copy link

@zlonghofer zlonghofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@dieser-niko dieser-niko merged commit 4f01f71 into master Mar 7, 2025
23 checks passed
@dieser-niko dieser-niko deleted the bugfix/621-session-type-error branch March 7, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Garbage collection sets requests.Session to None before __del__ is called (TypeError)
3 participants