BGD-3813 - limit the number of executors #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextarasov-spot
temporarily deployed
to
dev
GitHub Actions
Inactive
ImpSy
reviewed
Oct 2, 2023
ImpSy
reviewed
Oct 2, 2023
Co-authored-by: Sébastien Maintrot <3097030+ImpSy@users.noreply.github.com>
Co-authored-by: Sébastien Maintrot <3097030+ImpSy@users.noreply.github.com>
thorsteinnth
reviewed
Oct 2, 2023
added 2 commits
October 3, 2023 09:51
…tors' into BGD-3813-cap-the-number-of-executors # Conflicts: # pkg/controller/sparkapplication/controller.go
arnarpall
reviewed
Oct 3, 2023
arnarpall
approved these changes
Oct 3, 2023
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/3813
Description
We should cap the number of executors that the spark-operator processes and the size of the executors list in the SparkApplication CR status section
This will make sure that we do not DoS attack ourselves indefinitely by slowing down the SparkApplication CR processing (submitting apps and tracking driver pods is the highest priority of the spark-operator) and also that the executor list in the CR does not grow too large, causing
etcderrors when we try to patch / update the CRDemo
run the spark-operator with the
--executors-processing-limit=5argument, which will limit the number of processed executors to5Screen.Recording.2023-09-21.at.18.20.15.mov
Checklist
How to test
Description of environment setup necessary to exercise the feature and perform tests
Test plan and results
Feel free to add screenshots showing test results