Convert SortMergeBucketExample to Parquet + update tests #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5191 +/- ##
=======================================
Coverage 62.62% 62.63%
=======================================
Files 301 301
Lines 10842 10842
Branches 767 767
=======================================
+ Hits 6790 6791 +1
+ Misses 4052 4051 -1 ☔ View full report in Codecov by Sentry. |
clairemcginty
force-pushed
the
parquetify-smb-example
branch
from
4396d65
to
75a5fe4
Compare
clairemcginty
force-pushed
the
parquetify-smb-example
branch
from
78a010e
to
3339c10
Compare
clairemcginty
commented
Jan 29, 2024
RustedBones
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates SortMergeBucketExample to use Parquet writes (both typed and Avro) and demonstrate features like FilterPredicates, Projections, and Configurations. Also updates the unit tests to demonstrate the new
SmbIOfunctionality as well as the smb-write Tap functionality.Todo: