Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GcsConfiguration and deps to Sampling project #96

Merged
merged 1 commit into from
May 23, 2018
Merged

Move GcsConfiguration and deps to Sampling project #96

merged 1 commit into from
May 23, 2018

Conversation

idreeskhan
Copy link
Contributor

@idreeskhan idreeskhan requested a review from jbigred1 May 23, 2018 14:52
@codecov-io
Copy link

codecov-io commented May 23, 2018 •
edited
Loading

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   70.63%   70.63%           
=======================================
  Files          24       24           
  Lines        1049     1049           
  Branches      123      123           
=======================================
  Hits          741      741           
  Misses        308      308

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f0574...c2c4ac3. Read the comment docs.

jbigred1
jbigred1 approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@jbigred1 jbigred1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@idreeskhan idreeskhan merged commit 7055ecd into master May 23, 2018
@idreeskhan idreeskhan deleted the idrees/move-hadoop-dep branch May 23, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbigred1 jbigred1 jbigred1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idreeskhan @codecov-io @jbigred1