Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade guava to 0.20 to maintain consistency with Scio #73

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Downgrade guava to 0.20 to maintain consistency with Scio #73

merged 1 commit into from
Apr 13, 2018

Conversation

idreeskhan
Copy link
Contributor

@idreeskhan idreeskhan commented Apr 13, 2018 •
edited
Loading

#72

@idreeskhan
Copy link
Contributor Author

@jbigred1 @tkhduracell

jbigred1
jbigred1 approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@jbigred1 jbigred1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@idreeskhan idreeskhan merged commit d95dfc4 into master Apr 13, 2018
@codecov-io
Copy link

codecov-io commented Apr 13, 2018 •
edited
Loading

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files          22       22           
  Lines         947      947           
  Branches      119      127    +8     
=======================================
  Hits          664      664           
  Misses        283      283

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb3f80...ed6d028. Read the comment docs.

@idreeskhan idreeskhan deleted the idrees/guava-downgrade branch April 13, 2018 14:20
@tkhduracell
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbigred1 jbigred1 jbigred1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idreeskhan @codecov-io @tkhduracell @jbigred1