Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force FileSystems to load/register service classes #60

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Force FileSystems to load/register service classes #60

merged 1 commit into from
Mar 27, 2018

Conversation

idreeskhan
Copy link
Contributor

@idreeskhan idreeskhan commented Mar 26, 2018 •
edited
Loading

Addresses #59

@codecov-io
Copy link

codecov-io commented Mar 26, 2018 •
edited
Loading

Codecov Report

Merging #60 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   71.58%   71.64%   +0.06%     
==========================================
  Files          22       22              
  Lines         929      931       +2     
  Branches      124      123       -1     
==========================================
+ Hits          665      667       +2     
  Misses        264      264
Impacted Files Coverage Δ
...ala/com/spotify/ratatool/samplers/BigSampler.scala 65.86% <100%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5079ad5...1657853. Read the comment docs.

jbigred1
jbigred1 approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@jbigred1 jbigred1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@idreeskhan idreeskhan merged commit a887323 into master Mar 27, 2018
@idreeskhan idreeskhan deleted the idrees/filesystems branch March 27, 2018 19:28
@idreeskhan idreeskhan mentioned this pull request Mar 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbigred1 jbigred1 jbigred1 approved these changes

@ankscircle ankscircle Awaiting requested review from ankscircle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idreeskhan @codecov-io @jbigred1