BigDiffy output with header #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
idreeskhan
commented
Mar 21, 2018
•
idreeskhan
commented
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 71.58% 70.82% -0.77%
==========================================
Files 22 22
Lines 929 939 +10
Branches 124 123 -1
==========================================
Hits 665 665
- Misses 264 274 +10
Continue to review full report at Codecov.
|
jbigred1
reviewed
Mar 27, 2018
| def saveAsTextFileWithHeader(path: String, header: String): Future[Tap[String]] = { | ||
| val transform = TextIO.write() | ||
| .to(pathWithShards(path)) | ||
| .withSuffix(".txt") |
There was a problem hiding this comment.
do we want this to be .tsv since that's what it produces
There was a problem hiding this comment.
Theoretically it could be, but the existing code outputs .txt and I'm moving this header to be optional. I'd rather keep the file format/naming consistent.
jbigred1
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.