add check that GCS output begins with gs:// #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anne-decusatis
commented
Aug 19, 2019
| @@ -504,6 +505,13 @@ object BigDiffy extends Command { | |||
| case m => throw new IllegalArgumentException(s"output mode $m not supported") | |||
| } | |||
|
|
|||
| if (om == GCS && !output.startsWith("gs://")) { | |||
There was a problem hiding this comment.
is it in scope to fail fast similarly for BQ?
catherinejelder
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received a user report that Ratatool succeeded in running a diff but they didn't know where the result was output to. We should fail fast if the output location is invalid.