Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in multiple functions #102

Merged
merged 2 commits into from
Jun 11, 2018
Merged

adding in multiple functions #102

merged 2 commits into from
Jun 11, 2018

Conversation

jbigred1
Copy link
Contributor

@jbigred1 jbigred1 commented Jun 7, 2018

This will allow it so multiple functions can be provided to the amend functions now

Addresses #100

@jbigred1 jbigred1 requested a review from idreeskhan June 7, 2018 22:00
@codecov-io
Copy link

codecov-io commented Jun 7, 2018

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   71.31%   71.31%           
=======================================
  Files          24       24           
  Lines        1105     1105           
  Branches      125      131    +6     
=======================================
  Hits          788      788           
  Misses        317      317
Impacted Files Coverage Δ
...tify/ratatool/examples/scalacheck/GenExample.scala 100% <100%> (ø) ⬆️
...cala/com/spotify/ratatool/scalacheck/package.scala 65.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0322dc2...09d0d4b. Read the comment docs.

Copy link
Contributor

@idreeskhan idreeskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

m.setIndependentStringField(s)
m.setDependentEnumField(dependentEnumFunc(s))
})
.amend(intGen)(_.setIndependentIntField,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a nitpick but can we add the first function on a newline here, makes it more clear when reading the examples that it's doing two things

@jbigred1 jbigred1 merged commit 5ca49db into master Jun 11, 2018
@jbigred1 jbigred1 deleted the parameters branch June 11, 2018 14:57
@jbigred1 jbigred1 restored the parameters branch June 11, 2018 14:58
@jbigred1 jbigred1 deleted the parameters branch June 11, 2018 14:58
@jbigred1 jbigred1 restored the parameters branch June 11, 2018 14:58
@jbigred1 jbigred1 deleted the parameters branch June 11, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants