adding in examples and tests for amend2 generators #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 70.67% 71.31% +0.63%
==========================================
Files 24 24
Lines 1081 1105 +24
Branches 125 125
==========================================
+ Hits 764 788 +24
Misses 317 317
Continue to review full report at Codecov.
|
idreeskhan
reviewed
Jun 7, 2018
| "type": "STRING" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
newline, surprised if this isn't caught in style checks
idreeskhan
reviewed
Jun 7, 2018
| .tupled | ||
| .amend2(recordIdGen)(_.set("record_id"), _.set("record_id")) | ||
|
|
||
| val correlatedRecordGen: Gen[(TableRow, TableRow)] = |
There was a problem hiding this comment.
Can call a.map after to set the nested field so that the output is a single TableRow with the record ID fields correlated.
| private val tableRowGenDup: Gen[TableRow] = | ||
| tableRowOf(tableSchema) | ||
|
|
||
| val exampleRecordGen2: Gen[(TableRow, TableRow)] = |
There was a problem hiding this comment.
Can we name this something else. Maybe joinableExampleGen or something more descriptive. The name itself is up to you
|
👍 Good to merge when tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains examples for
amend2generatorsWill address #93