Add cocoapods support #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any plans on merging this in? It would be a major improvement over having to embed a 42Mb framework, that then sits in your repo unless you want to deal with submodules. |
thejohnlima
reviewed
Mar 20, 2020
Spotify-SDK.podspec
Outdated
| Pod::Spec.new do |s| | ||
|
|
||
| s.name = "Spotify-SDK" | ||
| s.version = "1.0.2" |
There was a problem hiding this comment.
The currently latest version is 1.2.2
|
Were you be able to get the build works after run pod install? Podfile: I'm getting a build failed: |
camiletti
force-pushed
the
add-cocoapods-support
branch
from
d67621c to
ef012ba
Compare
|
Also would love to have this :) |
|
I suggest this PR be closed due to inactivity and the fact that cocoapods is no more: |
|
What do you mean, react native heavily relies on pods even in the latest versions |
|
This code is 6 years old. Safe to say it’s no longer mergable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be great if the Spotify SDK would be officially available on CocoaPods as it makes dependency management so much easier
Checklist if approved: