Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings generated because of connection leak #47

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

aleerizw
Copy link
Contributor

body should be closed

ref: square/okhttp#2311

Currently warnings are generated from okhttp:

com.spotify.githubclient.shade.okhttp3.internal.platform.Platform log
WARNING: A connection to https://ghe.spotify.net/ was leaked. Did you forget to close a response body?
To see where this was allocated, set the OkHttpClient logger level to FINE: Logger.getLogger(OkHttpClient.class.getName()).setLevel(Level.FINE);

body should be closed

ref: square/okhttp#2311

Currently warnings are generated from okhttp:

```
com.spotify.githubclient.shade.okhttp3.internal.platform.Platform log
WARNING: A connection to https://ghe.spotify.net/ was leaked. Did you forget to close a response body?
To see where this was allocated, set the OkHttpClient logger level to FINE: Logger.getLogger(OkHttpClient.class.getName()).setLevel(Level.FINE);
```
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #47 (fffd034) into master (27a77ca) will increase coverage by 2.86%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
+ Coverage     65.80%   68.66%   +2.86%     
- Complexity      176      195      +19     
============================================
  Files            30       32       +2     
  Lines           731      766      +35     
  Branches         29       33       +4     
============================================
+ Hits            481      526      +45     
+ Misses          229      217      -12     
- Partials         21       23       +2     
Impacted Files Coverage Δ Complexity Δ
...va/com/spotify/github/v3/prs/ReviewParameters.java 100.00% <ø> (+100.00%) 1.00 <0.00> (+1.00)
...m/spotify/github/v3/clients/PullRequestClient.java 26.41% <63.63%> (+26.41%) 5.00 <2.00> (+5.00)
...om/spotify/github/v3/clients/RepositoryClient.java 64.15% <66.66%> (+0.07%) 28.00 <1.00> (+1.00)
...va/com/spotify/github/v3/clients/GitHubClient.java 74.77% <80.00%> (+5.61%) 50.00 <11.00> (+9.00)
...com/spotify/github/v3/clients/GithubAppClient.java 75.00% <100.00%> (+3.57%) 4.00 <1.00> (+1.00)
...spotify/github/v3/prs/RequestReviewParameters.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
.../java/com/spotify/github/v3/prs/ReviewComment.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa142d0...fffd034. Read the comment docs.

@aleerizw aleerizw merged commit 8008021 into master Dec 23, 2020
@aleerizw aleerizw deleted the fix-okhttp-warnings branch December 23, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants