Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Use absolute classpath as input #199

Merged
merged 3 commits into from
Dec 11, 2018
Merged

Conversation

asaenf
Copy link
Contributor

@asaenf asaenf commented Dec 11, 2018

Hey I just made a pull request

Description

When updating to this version of Flo, our jobs failed to execute as it was unable to find the ForkingExecutor class. This was due to the arguments passed in to the classPath variable were not absolute Paths.

Motivation and Context

When updating to this version of Flow, our jobs failed to execute as it was unable to find the ForkingExecutor class. This was due to the arguments passed in to the classPath variable were not absolute Paths.

Have you tested this? If so, how?

We have tested this by running it locally, its not possible to unit test as the class path is determined by the environment.

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@honnix honnix merged commit 27303c0 into spotify:master Dec 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants