This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Upgrade to jnr-unixsocket 0.18 #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
force-pushed
the
dxia/upgrade-jnr
branch
from
a8d582e to
495ec57
Compare
This was referenced Nov 12, 2017
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
===========================================
+ Coverage 66.08% 66.78% +0.7%
+ Complexity 771 754 -17
===========================================
Files 171 170 -1
Lines 3249 3158 -91
Branches 372 370 -2
===========================================
- Hits 2147 2109 -38
+ Misses 942 892 -50
+ Partials 160 157 -3 |
davidxia
force-pushed
the
dxia/upgrade-jnr
branch
2 times, most recently
from
fefef9c to
8231422
Compare
|
I guess the comment is no longer valid re: delaying the socket options? https://github.com/spotify/docker-client/pull/918/files#diff-a479355e73762bc07b466a285d105088L41 I'm fine with this given that tests pass. |
caipre
previously approved these changes
Nov 14, 2017
|
@caipre Yea, I think |
mattnworb
suggested changes
Nov 15, 2017
| @Rule | ||
| public ExpectedException exception = ExpectedException.none(); | ||
|
|
||
| private static UnixConnectionSocketFactory sut; |
There was a problem hiding this comment.
I don't think this needs to be static when it is reused in all @Tests
davidxia
force-pushed
the
dxia/upgrade-jnr
branch
from
8231422 to
88721f0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use upstream UnixSocket instead of our own ApacheUnixSocket wrapper.