Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Commit

Permalink
Remove DockerDateFormat
Browse files Browse the repository at this point in the history
This library was originally using Java 7. Java 7 had `Date` objects
with only millisecond resolution.

This was a problem when translating timestamps with nanosecond
precision from the Docker API to `Date`.

This library is on Java 8 now which supports nanosecond resolution.

This PR fixes the findbugs error here #1068.
See build logs https://travis-ci.org/spotify/docker-client/jobs/426781589.
  • Loading branch information
davidxia committed Oct 2, 2018
1 parent 5256d39 commit ad82870
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 154 deletions.
6 changes: 0 additions & 6 deletions findbugs-exclude.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,4 @@
<Bug pattern="SE_BAD_FIELD"/>
</Match>

<Match>
<Class name="com.spotify.docker.client.DockerDateFormat" />
<Method name="clone" />
<Bug pattern="CN_IDIOM_NO_SUPER_CALL" />
</Match>

</FindBugsFilter>
70 changes: 0 additions & 70 deletions src/main/java/com/spotify/docker/client/DockerDateFormat.java

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ public Object apply(final Object input) {
OBJECT_MAPPER.registerModule(MODULE);
OBJECT_MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
OBJECT_MAPPER.setSerializationInclusion(JsonInclude.Include.NON_NULL);
OBJECT_MAPPER.setDateFormat(new DockerDateFormat());
} catch (Throwable t) {
log.error("Failure during static initialization", t);
throw t;
Expand Down
77 changes: 0 additions & 77 deletions src/test/java/com/spotify/docker/client/DockerDateFormatTest.java

This file was deleted.

0 comments on commit ad82870

Please sign in to comment.