Add build support for jdk 11 - fixes #2598 #2604
Conversation
|
Requires junit 5 changes before this will work. More specifically it requires a single code change to tests as a bad test exists here on java 11 so its disabled specifically on java 11 with code updates for junit 5. |
|
Toolchains will be added back at later date in same way once we move to requiring java 17. For now this shows a bit more of what we support with obvious caveat that java 8 is not shown here. |
hazendaz
changed the title
.github/workflows/build.yml
Outdated
| @@ -9,39 +9,41 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, windows-latest, macos-latest] | |||
| java: [11, 17, 20] | |||
There was a problem hiding this comment.
It's stated in #2598:
Originally I wanted jdk 21 to show case it working due to various user inquires but fact of the matter is gradle doesn't support it yet until 8.4 and still won't with kotlin which means we cannot actually show that. So that is where jdk 20 comes into place.
|
Kotlin doesn't support 21 yet so by extension neither does gradle for that reason. If we didn't have kotlin scripts in our build it would work.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Judit Knoll ***@***.***>
Sent: Thursday, October 5, 2023 2:20:58 AM
To: spotbugs/spotbugs ***@***.***>
Cc: Jeremy Landis ***@***.***>; Assign ***@***.***>
Subject: Re: [spotbugs/spotbugs] Add build support for jdk 11 and 20 - fixes #2598 (PR #2604)
@JuditKnoll commented on this pull request.
________________________________
In .github/workflows/build.yml<#2604 (comment)>:
@@ -9,39 +9,41 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
+ java: [11, 17, 20]
It's stated in #2598<#2598>:
Originally I wanted jdk 21 to show case it working due to various user inquires but fact of the matter is gradle doesn't support it yet until 8.4 and still won't with kotlin which means we cannot actually show that. So that is where jdk 20 comes into place.
—
Reply to this email directly, view it on GitHub<#2604 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI76IZ2A23GBWNFNPCLX5ZGUVAVCNFSM6AAAAAA5TQUK3KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJYHE2TEMRUG4>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
|
I'll post the specific error on that shortly for clarity
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Jeremy Landis ***@***.***>
Sent: Thursday, October 5, 2023 8:45:09 AM
To: spotbugs/spotbugs ***@***.***>; spotbugs/spotbugs ***@***.***>
Cc: Assign ***@***.***>
Subject: Re: [spotbugs/spotbugs] Add build support for jdk 11 and 20 - fixes #2598 (PR #2604)
Kotlin doesn't support 21 yet so by extension neither does gradle for that reason. If we didn't have kotlin scripts in our build it would work.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Judit Knoll ***@***.***>
Sent: Thursday, October 5, 2023 2:20:58 AM
To: spotbugs/spotbugs ***@***.***>
Cc: Jeremy Landis ***@***.***>; Assign ***@***.***>
Subject: Re: [spotbugs/spotbugs] Add build support for jdk 11 and 20 - fixes #2598 (PR #2604)
@JuditKnoll commented on this pull request.
________________________________
In .github/workflows/build.yml<#2604 (comment)>:
@@ -9,39 +9,41 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
+ java: [11, 17, 20]
It's stated in #2598<#2598>:
Originally I wanted jdk 21 to show case it working due to various user inquires but fact of the matter is gradle doesn't support it yet until 8.4 and still won't with kotlin which means we cannot actually show that. So that is where jdk 20 comes into place.
—
Reply to this email directly, view it on GitHub<#2604 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI76IZ2A23GBWNFNPCLX5ZGUVAVCNFSM6AAAAAA5TQUK3KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJYHE2TEMRUG4>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
|
Why jdk 21 not here... |
|
going to partially use this and leave rest to look at later. Not sure why but it wants to download latest components from eclipse. Its been about 2 month since I last worked on this but seem to recall jdk 11 working then, now it does not. Looked over changes not seeing it but don't want to hold up release tonight. Will however peel off parts of this (ie jdk 21 parts). |
I think the java version of the downloaded eclipse's code is too new for java 11 (see #2589). We would need eclipse 4.24 or older to support java 11 (see https://wiki.eclipse.org/Eclipse/Installation). |
|
guessing the issue is osgi related, need to look more into it. Its pulling almost the latest binaries which is the problem. |
hazendaz
changed the title
temurin does not have jdk 21 yet so zulu is generally head, switching to future proof
|
found issue, will be pushing up shortly... |
* [GHA] Add jdk 11 temurin does not have jdk 21 yet so zulu is generally head, switching to future proof * [eclipse] Drop back to 4.24 to allow jdk 11 usage * [spring] Drop back to 5.3.31 as we are not on jakarta yet * [java11] Drop back logic for java 11 builds * [eclipse] Drop binary pull back to 4.24 and add change log
fixes #2598