Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from staging repo to release v4.0.0 #191

Merged
merged 237 commits into from
Mar 3, 2020
Merged

Conversation

KengoTODA
Copy link
Member

@KengoTODA KengoTODA commented Feb 23, 2020

Replace all things forked from old FindBugs gradle plugin with newly created one from scratch.
Now both of copyright holder and license holder are SpotBugs team.

It also depends on no internal package from Gradle, so we hope that broken backward compatibility won't be introduced so frequently.

After we merge this PR, we need to handle following operations:

TO contributors: I cannot find who enables GitHub Sponsors. When you enabled it, please consider to submit PR to update .github/FUNDING.yml to list your account.

close #178
close #180

SpotBugsTask class should not be abstract, to let users instantiate it
by `task(type: ...SpotBugsTask)`.
Gradle plugin should ignore other files such as .xml, .txt, .properties
and so on. Only .class files should be considered as the target to
analyse by default.

fix #89
BREAKING CHANGE: all the implementations are written from scratch
Emacs support, `sourceSets` property, and some features are dropped
intentionally.
@KengoTODA
Copy link
Member Author

Travis is failing, but we can ignore it because we do not use Travis from this version.
I'll disable Travis from coming builds.

@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 9 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@KengoTODA
Copy link
Member Author

@spotbugs/everyone please review this PR. This PR contains many changes, but important points are limited:

e2bdae0 remove all existing files
9396a49 merge changes from the staging repo
eaa3459 update URLs and metadata, to release the new plugin as new version of existing plugin

Note that this PR is not able to be merged by rebase and merge because this PR contains a merge with --allow-unrelated-histories option. I'll use squash and merge instead.

Copy link
Contributor

@jscancella jscancella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a task to add more documentation to the classes. In general they are readable, but just to make it easier for those who aren't as familiar with the "new" java 8 lambda expressions and what each class should be doing.

Looks great to me, thanks for all the hard work!

@KengoTODA KengoTODA merged commit 3e88cd4 into master Mar 3, 2020
@KengoTODA KengoTODA deleted the merge-from-staging-repo branch March 3, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Reimplementing this Gradle Plugin from Scratch
5 participants