Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test and fix logging callback #194

Merged
merged 5 commits into from
Apr 16, 2024
Merged

test and fix logging callback #194

merged 5 commits into from
Apr 16, 2024

Conversation

scottlamb
Copy link
Collaborator

No description provided.

@scottlamb scottlamb requested a review from Xaeroxe April 16, 2024 17:11
Xaeroxe
Xaeroxe previously approved these changes Apr 16, 2024
Copy link
Contributor

@Xaeroxe Xaeroxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

I'm looking forward to <rust-lang/cargo#6179>;
making an entire crate empty or not based on platform is an awkward
workaround.
@Xaeroxe Xaeroxe merged commit bb8c79c into main Apr 16, 2024
5 checks passed
@Xaeroxe Xaeroxe deleted the test-logging branch April 16, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants