Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spys and mocks #5

Open
wyuenho opened this issue Mar 24, 2013 · 3 comments
Open

spys and mocks #5

wyuenho opened this issue Mar 24, 2013 · 3 comments

Comments

@wyuenho
Copy link

wyuenho commented Mar 24, 2013

Jasmine has a very simple spy and mock facility, it would be nice if this library could incorporate that.

@spmason
Copy link
Owner

spmason commented Mar 25, 2013

I'm not convinced about adding spys/mocks, I tend to prefer to use sinon directly and it keeps the size/complexity down without it.

That doesn't mean I wouldn't accept a pull request for it though, but I'd prefer it to be a separate file/module from the main library to keep the size down. It could still just be a wrapper around sinon (like what jasmine does)

@wyuenho
Copy link
Author

wyuenho commented Mar 26, 2013

Jasmine doesn't wrap Sinon. Jasmine has a minimalist spy/mock system. I was thinking more like exposing Jasmine's minimalist spy/mock API by wrapping Sinon and Sinon's API. So lazy people like me who are too lazy to look up Sinon's 300 odd methods can keep our heads from exploding, but then the high-level API isn't enough, I can drop down to Sinon.

@spmason
Copy link
Owner

spmason commented Mar 27, 2013

A wrapper around sinon sounds good, would be great to see a pull request
for it :)

On 26 March 2013 04:29, Jimmy Yuen Ho Wong notifications@github.com wrote:

Jasmine doesn't wrap Sinon. Jasmine has a minimalist spy/mock system. I
was thinking more of exposing Jasmine's minimalist spy/mock API by wrapping
Sinon and Sinon's API. So lazy people like me who are too lazy to look
up Sinon's 300 odd methods can keep our heads from exploding.


Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-15440508
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants