Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide new workflow to package .vsix #98

Merged
merged 12 commits into from
Jul 17, 2023
Merged

Provide new workflow to package .vsix #98

merged 12 commits into from
Jul 17, 2023

Conversation

fantavlik
Copy link
Collaborator

@fantavlik fantavlik commented Jul 17, 2023

I was noticing that the .vsix generated for release using vsce package is very dependent on the individual user's environment so I wanted to provide a way to make this more reproducible in CI.

The workflow is triggered when a new tag is pushed, a test tag run can be seen here after I pushed the 0.3.1-beta1 tag: https://github.com/splunk/vscode-extension-splunk/actions/runs/5571074169

Under the job summary a zip file containing the generated .vsix can be seen at the bottom of the page under Artifacts:
image

Two other fixes that were made

  • Added an overrides section to account for peer dependencies using older incompatible versions of react, react-dom and styled-components, these changes match the 0.3.0 release so there shouldn't be any actual dependency changes here 🤞
  • Added (back) some axios header code to handle various versions of axios in a backwards compatible way - npm was resolving this dependency in various ways and this ensures that all versions of axios will work out-of-the-box

@fantavlik fantavlik requested a review from JasonConger July 17, 2023 02:25
@JasonConger JasonConger merged commit 6fc806c into master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants