Fix problem with variables in comments #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesplunker
reviewed
Jul 12, 2023
| @@ -129,7 +129,7 @@ export function dispatchSpl2Module(service: any, spl2Module: string, app: string | |||
| namespace = ''; | |||
| app = app || 'search'; // default to search app | |||
| // Get last statement assignment '$my_statement = ...' -> 'my_statement' | |||
| const statementMatches = [...spl2Module.matchAll(/\$([a-zA-Z0-9_]+)[\s]*=/gm)]; | |||
| const statementMatches = [...spl2Module.matchAll(/^\s*\$([a-zA-Z0-9_]+)[\s]*=/gm)]; | |||
There was a problem hiding this comment.
seems to be still matching inside doc comment, are we cool with that for now?
There was a problem hiding this comment.
My bad. We're targetting fix for single line comments for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to detect variables in SPL2 code is a bit primitive at the moment and currently will catch commented-out variables. This tweaks the regex to require a variable to occur at the start of the line with just whitespace before it.