Spl2 fixes #89
Spl2 fixes #89
Conversation
| @@ -112,6 +123,64 @@ export async function addVisualizationPreference( | |||
| await controller.runCell(cell); | |||
| } | |||
|
|
|||
| export async function enterEarliestTime( | |||
There was a problem hiding this comment.
nit: not a big deal at all, but these two functions seem to share logic. Totally ok to keep them this way if refactoring is pain.
There was a problem hiding this comment.
I actually had the same thought and started to refactor it, but it ultimately only saved ~4 lines of code due to the multiple places where the two differ and ended up having a lot of indirection which made it harder to read so I reverted to this.
There was a problem hiding this comment.
Honestly, then this is way better :) 4 lines ain't worth it
| @@ -64,6 +91,11 @@ export class CellResultCountStatusBarProvider implements vscode.NotebookCellStat | |||
| "arguments": [cell] | |||
| } | |||
| }); | |||
| // earliest and latest time pickers are only supported for SPL2 at the moment | |||
There was a problem hiding this comment.
One is for the state when the job hasn't been run yet and the other is for the state where there are outputs from the job. There are a different set of icons for each.
Before:
After (with job details):
| // TODO: Remove this hardcoded version/update time and check for updates | ||
| let lspVersion: string = '2.0.362'; // context.globalState.get(stateKeyLatestLspVersion) || ""; | ||
| let latestLspVersion: string = '2.0.362'; // context.globalState.get(stateKeyLatestLspVersion) || ""; | ||
| const lastUpdateMs: number = Date.now(); // context.globalState.get(stateKeyLastLspCheck) || 0; |
There was a problem hiding this comment.
This is my way of turning the feature off for now until I have a chance to flesh out the issues I was seeing with retrieving the latest version from maven metdata, related to the TODO above
| app: "apps.search", | ||
| }; | ||
|
|
||
| let indx = 1; |
There was a problem hiding this comment.
yeah I'm saving these as module1, module2, etc to be human readable.
Provide better error handling and configurability for language server download and install by allowing user to specify custom path to LSP file
Fix issue with progress bars getting stuck
Allow users to input earliest and latest times
Demo:
Serialize the format for SPL2 notebooks saved to disk to more closely match modules.json expectations, example:
{ "modules": [ { "name": "module1", "namespace": "", "definition": "$q1 = from _internal where log_level != \"ERROR\"", "_vscode": { "metadata": { "splunk": { "earliestTime": "-24h", "latestTime": "now" } }, "outputs": [] } }, { "name": "module2", "namespace": "", "definition": " $q2 = from main", "_vscode": { "metadata": { "splunk": { "earliestTime": "@d", "latestTime": "now" } }, "outputs": [] } } ], "app": "apps.search" }