Add ability to dispatch SPL2 via SPL2 Notebooks #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work still needed to serialize to the correct format.
fantavlik
commented
Jun 5, 2023
| @@ -11,19 +11,17 @@ import { | |||
| import { splunkMessagesToOutputItems } from './utils'; | |||
|
|
|||
| export class SplunkController { | |||
There was a problem hiding this comment.
All the changes to this file were simply to make it easier to extend/inherit this class to reuse most of the code in here.
fantavlik
commented
Jun 5, 2023
Add support for notebook commands Fix job status updates for in-progress jobs Add better error handling for dispatch responses
|
@fantavlik this MR LGTM! I don't have approve permission. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off the existing SPL Notes feature, provide new functionality to execute SPL2 as search jobs (for Splunk deployments supporting the
/services/search/spl2-module-dispatchendpoint), and view results.To try this out:
/services/search/spl2-module-dispatch:Splunk Rest UrlToken.spl2nbextension or files namedmodules.json.I also drafted this Wiki page to add once this work merges: https://github.com/fantavlik/vscode-extension-splunk/wiki/Splunk-Notebooks