Update defaults and fix setting of some 0 values. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zscholl
force-pushed
the
zscholl/saved-search-defaults
branch
from
3a980f0
to
b9585fc
Compare
|
👋 Hey @anushjay, anything I can do here to help get this merged? |
julada
approved these changes
May 6, 2022
|
@micahkemp-splunk can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the values are
Computed: trueterraform ends up usingfalsefor boolean values and0for integer values. In some cases this is not the true default value when creating a saved search, so this produces behavior that's inconsistent with creating a new alert through the Splunk UI.Changing these defaults here to match Splunk's defaults for saved searches.
This change also removes some
omitemptytags for integer values when transforming the struct tourlparameters. Go's behavior is to consider0as an empty value so if the integer was set to0the field was not being included in the POST request to Splunk. This made it impossible to set one of these values to0.This issue is similar to #35, but concerns integer values.