Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Highcharts License. #119

Merged
merged 10 commits into from
Sep 24, 2021
Merged

Updated Highcharts License. #119

merged 10 commits into from
Sep 24, 2021

Conversation

rmaheshwari-splunk
Copy link
Contributor

Added LICENSE-HIGHCHARTS.txt and updated README.md regarding the same.

@rmaheshwari-splunk
Updated HighCharts License.
fd1aba7 
Added LICENSE-HIGHCHARTS.txt and updated README.md regarding the same.
fantavlik
fantavlik requested changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been asked to pause on this update until Legal has had a chance to review. Let's move this to WIP state for now and remove the ticket from our Sprints

@ashah-splunk ashah-splunk marked this pull request as draft June 16, 2021 04:47
@rmaheshwari-splunk
Copy link
Contributor Author

We've been asked to pause on this update until Legal has had a chance to review. Let's move this to WIP state for now and remove the ticket from our Sprints

Duly noted, we'll do the needful.

@ashah-splunk ashah-splunk changed the base branch from DVPL-9114 to develop September 21, 2021 08:28
@ashah-splunk ashah-splunk marked this pull request as ready for review September 21, 2021 10:18
@ncanumalla-splunk
Copy link

This looks good ! 👍

@ashah-splunk ashah-splunk merged commit f6647ad into develop Sep 24, 2021
@ashah-splunk ashah-splunk deleted the DVPL-7223 branch December 8, 2021 07:37
@vmalaviya-splunk vmalaviya-splunk mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantavlik fantavlik fantavlik approved these changes

@zenmoto zenmoto Awaiting requested review from zenmoto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmaheshwari-splunk @ncanumalla-splunk @fantavlik @ashah-splunk