Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add comments and errors class #1037

Merged
merged 3 commits into from
Jul 17, 2024
Merged

chore: add comments and errors class #1037

merged 3 commits into from
Jul 17, 2024

Conversation

ajasnosz
Copy link
Collaborator

@ajasnosz ajasnosz commented Jul 15, 2024 •
edited
Loading

Description

Fix sonarqube issues.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Refactor/improvement

How Has This Been Tested?

unit test

Checklist

  • My commit message is conventional
  • I have run pre-commit on all files before creating the PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ajasnosz ajasnosz requested a review from wojtekzyla July 15, 2024 08:58
@ajasnosz ajasnosz merged commit 89998a2 into develop Jul 17, 2024
10 of 11 checks passed
@ajasnosz ajasnosz deleted the chore/add-comments branch July 17, 2024 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
@srv-rr-github-token
Copy link
Contributor

🎉 This issue has been resolved in version 1.11.0-beta.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wojtekzyla wojtekzyla wojtekzyla approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajasnosz @srv-rr-github-token @wojtekzyla