-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Rule Updates #3271
Merged
Merged
Multiple Rule Updates #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated detection description to better explain ProxyShell (CVE-2021-34473, CVE-2021-34523, CVE-2021-31207) and ProxyNotShell (CVE-2022-41040, CVE-2022-41082) attack patterns - Enhanced search query: - X-Rps-CAT parameter - Suspicious user agent strings
@nasbench , for consistency : i think the detections that are now status: deprecated, we should move those files to the deprecated folder in the detections/ directory! That may also help with the build related errors on this CI |
…into major-updates
ljstella
reviewed
Jan 23, 2025
the detection passed on the second attempt in the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces multiple changes and updates to the following analytics.
Deprecated Analytics
Office Analytics
The following analytics related to misuse of office products, were deprecated in favor of a more generic approach. This is in order to ease management of the rule. Instead of managing 13~ or so rules, now we can deal with a single source of truth with a defined macro that can be updated to add additional office processes.
The above were replaced by
Windows Office Product Spawned Uncommon Process
/ 55d8741c-fa32-4692-8109-410304961eb8. This rule groups all of these child processes into a single analytic.Account Discovery With Net App / 339805ce-ac30-11eb-b87d-acde48001122
This analytic was a TTP that focused on unrelated things and called
account discovery
. Since there were other detection that overlapped with it. I choose to deprecate it, and replace it with an updated version of339805ce-ac30-11eb-b87d-acde48001122
/Windows Excessive Usage Of Net App
.Attempted Credential Dump From Registry via Reg exe / e9fb4a59-c5fb-440a-9f24-191fbc6b2911
This analytic overlapped had some overlap with another one, hence the deprecation. It was replaced by
8bbb7d58-b360-11eb-ba21-acde48001122
/Windows Sensitive Registry Hive Dump Via CommandLine
Detect Critical Alerts from Security Tools / 483e8a68-f2f7-45be-8fc9-bf725f0e22fd
As discussed internally, this analytic was too generic for an analyst to do anything with it. It was deprecated in favor of the more specific approach provided by analytics such as
Microsoft Defender ATP Alerts
andMicrosoft Defender Incident Alerts
. Going forward analytics from leveraging alerts from vendors will have their specific analytics.Domain Account Discovery With Net App / 98f6a534-04c2-11ec-96b2-acde48001122
This analytic was a TTP that looked only for commands that tries to query info about the users via
net user /do
. This had a couple of issues, such as triggering on creation of users via the/add
flag etc..It was deprecated in favor of a more tighter approach in
5d0d4830-0133-11ec-bae3-acde48001122
Domain Group Discovery With Net / f2f14ac7-fa81-471a-80d5-7eb65c3c7349
Net Localgroup Discovery / 54f5201e-155b-11ec-a6e2-acde48001122
Both of these analytics were deprecated in favor of
c5c8e0f3-147a-43da-bf04-4cfaec27dc44
/Windows Group Discovery Via Net
Remote System Discovery with Net / 9df16706-04a2-41e2-bbfe-9b38b34409d3
This analytic was focusing on 2 separate and unrelated type of threats or actions. It was split into other analytics, namely:
Renamed Analytics
Updated Analytics
Auditd Analytics
All Auditd analytics leveraging the data source
Linux Auditd Execve
have been updated to include a rename that will help with the integration with ES. Namelyrename comm as process_name | rename exe as process
Other