Strict yml from rba #3269
Open
Strict yml from rba #3269
+2,510
−22,439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookup ymls
this involved renaming some CSVs to remove the dates from them or force their naming schema to match the corresponding YML name for CSV detections
…. also ensure the each kvstore begins with _key.
related_fields, and risk_score from detections
misnamed fields, in endpoint detections
cleanup after new validations introduced
15 tasks
…ity_content into strict_yml_from_rba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove fields from YMLs that no longer exist in object definitions.
However, the script that did the rewriting introduced a number of formatting differences
on many fields, making the actual changes harder to parse out.