feat: adding CLEAN_KEYS support #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemrys
reviewed
Jul 18, 2024
| @@ -57,6 +57,14 @@ def props(self) -> Optional[Dict]: | |||
| self._props = self._conf_parser.item_dict() | |||
| return self._props if self._props else None | |||
|
|
|||
| def update_field_names(self, field_list) -> List: | |||
There was a problem hiding this comment.
Can you please type field_list here and specify the return type as well?
| """ | ||
| update field names to remove all the non-alphanumeric chars and replace them with _ | ||
| """ | ||
| for index in range(len(field_list)): |
There was a problem hiding this comment.
Can we do for field in field_list?
kdoroszko-splunk
approved these changes
Jul 23, 2024
mkolasinski-splunk
requested changes
Jul 23, 2024
| @@ -22,6 +22,23 @@ SOURCE_KEY = event_id | |||
| DELIMS = "=" | |||
| FIELDS = server_contact_mode, dest | |||
|
|
|||
| # Component tested: REPORT, DELIM-FIELDS-SOURCE_KEY | |||
| # Scenario:# Similar to the above scenario | |||
| ## ## server-contact-mode should be searched as server_contact_mode as CLEAN_KEYS = true by default | |||
There was a problem hiding this comment.
CLEAN_KEYS is set to false here, so how should this field be looked for? Just description requires small adjustment.
mkolasinski-splunk
approved these changes
Jul 24, 2024
|
🎉 This issue has been resolved in version 5.3.0-beta.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This issue has been resolved in version 5.4.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for CLEAN_KEYS in Transforms.conf.
Added respective e2e test case for the same
Impact on Addons:
Now if Addons have have field names in transforms report which have non-alphanumeric chars then those chars would be first converted to _ and then tests would be generated as by default in splunk CLEAN_KEYS is set to true, so splunk also does the same thing.
Moreover if any report stanza has explicitly set CLEAN_KEYS=false then for those reports field conversion would not happen and tests would be generated as it is.