Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HEC endpoint to be configured #222

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Allow HEC endpoint to be configured #222

merged 2 commits into from
Apr 13, 2022

Conversation

vears91
Copy link
Contributor

@vears91 vears91 commented Mar 14, 2022

Proposed changes

Allow the HEC endpoint to be configured, instead of using the hardcoded services/collector endpoint. Closes #221

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@vears91 vears91 mentioned this pull request Mar 18, 2022
Merged
7 tasks
@hvaghani221
Copy link
Contributor

Can you resolve the conflict? I can merge these changes. But helm chart's changes can only be merged when the plugin changes are released.

@vears91
Copy link
Contributor Author

vears91 commented Apr 12, 2022 •
edited
Loading

Can you resolve the conflict? I can merge these changes. But helm chart's changes can only be merged when the plugin changes are released.

Hi @harshit-splunk, I have solved the conflict

hvaghani221
hvaghani221 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@hvaghani221 hvaghani221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@hvaghani221 hvaghani221 merged commit 118d233 into splunk:develop Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvaghani221 hvaghani221 hvaghani221 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow HEC endpoint to be configured
2 participants
@vears91 @hvaghani221