add secret: true
to hec_token config_param such that it is redacted…
#201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Conor Evans coevans@tcd.ie
Proposed changes
Set
secret
parameter totrue
for thehec_token
config_param. This will mask the output within the output of the configuration. The relevant fluentd code: https://github.com/fluent/fluentd/blob/5844f7209fec154a4e6807eb1bee6989d3f3297f/lib/fluent/config/element.rb#L160-L183Types of changes
What types of changes does your code introduce?
Checklist
Put an
x
in the boxes that apply.I didn't add a test because I didn't see a fitting way to add one. If you do, you can find an example in fluentd's core lib:https://github.com/fluent/fluentd/blob/5844f7209fec154a4e6807eb1bee6989d3f3297f/test/config/test_element.rb#L290