Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add secret: true to hec_token config_param such that it is redacted… #201

Merged
merged 1 commit into from
Dec 14, 2021
Merged

add secret: true to hec_token config_param such that it is redacted… #201

merged 1 commit into from
Dec 14, 2021

Conversation

conorevans
Copy link
Contributor

Signed-off-by: Conor Evans coevans@tcd.ie

Proposed changes

Set secret parameter to true for the hec_token config_param. This will mask the output within the output of the configuration. The relevant fluentd code: https://github.com/fluent/fluentd/blob/5844f7209fec154a4e6807eb1bee6989d3f3297f/lib/fluent/config/element.rb#L160-L183

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

I didn't add a test because I didn't see a fitting way to add one. If you do, you can find an example in fluentd's core lib:https://github.com/fluent/fluentd/blob/5844f7209fec154a4e6807eb1bee6989d3f3297f/test/config/test_element.rb#L290

… in the configuration file output

Signed-off-by: Conor Evans <coevans@tcd.ie>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants