Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus 2.1.0 upgrade #171

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Conversation

ahma
Copy link
Contributor

@ahma ahma commented Jun 7, 2021

Proposed changes

Support for 2.1.0 prometheus library.
Based on the following issue

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@ahma ahma force-pushed the feature/prometheus_2_support branch from 6d07c6b to 4a3b1bf Compare June 7, 2021 15:39
@zonito
Copy link

zonito commented Jun 18, 2021

Any update on this?

@ahma
Copy link
Contributor Author

ahma commented Jun 21, 2021

Any update on this?

yeh sorry, the pr is now mergeable, all the tests are passed.

@zonito
Copy link

zonito commented Jun 23, 2021

It works for me! Someone from Splunk team can merge and take it further.

Thanks @ahma

Copy link
Contributor

@rockb1017 rockb1017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rockb1017 rockb1017 merged commit 7da9fc0 into splunk:develop Jul 12, 2021
@ahma ahma deleted the feature/prometheus_2_support branch July 12, 2021 21:59
rockb1017 added a commit that referenced this pull request Jul 20, 2021
* Workaround false warning: parameter 'x' in <fields> is not used. (#168)

record_transformer uses the `has_key()` method, not the `key()` method.

Closes  #161

* upgrade nodejs (#172)

* Prometheus 2.1.0 upgrade  (#171)

* Prometheus-Client upgrade 0.10.0 -> 2.1.0

* GemLock update

* - label fix

* lib update (#177)

* lib update

* version

Co-authored-by: Thomas Mueller <thomas@chaschperli.ch>
Co-authored-by: Ferenc HERNADI <ferenc.hernadi@gmail.com>
@rwterryfl
Copy link

Apologies for being new at this, but when will this update be released? I see Version 1.2.7 as "latest" which was prior to this merge. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants