-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): merge develop to main #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description This is not a breaking change for the reusable workflow, updating version of the action to v3.0. This PR will be followed up with a template change. Tested - splunk/addonfactory-ucc-generator#1525. ### Checklist - [x] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releaes test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
TA-> TA Upgrade implementation ADDON-73792 This pull request introduces a new feature to our CI/CD pipeline, focusing on automating upgrade testing for Technology Add-ons (TA). The goal is to streamline the release process by incorporating scalable and user-friendly solutions capable of executing upgrade scenarios Key Features: Automated Upgrade Testing: Introduces jobs for upgrade testing within the GitHub CI/CD pipeline. Flexible Version Testing: Allows users to provide multiple TA versions on which upgrade tests should be executed. In this repo, ta_upgrade_version parameter is responsible for passing the info about versions being tested. Also, both GitHub and Splunkbase releases are supported, depending on the format of the version string provided: vX.X.X - for GitHub releases X.X.X - for Splunkbase releases additionally, latest can be passed to use the latest version from GitHub example run - https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/12045945177 Part of splunk/ta-automation-app-of-apps#27 splunk/ta-automation-k8s-manifests#102 splunk/wfe-test-runner-action#35 --------- Co-authored-by: Adam Wownysz <awownysz@splunk.com>
This updates k8s-manifests and runner image versions so that upgrade tests can run correctly.
### Description (PR description goes here) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releaes test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description This PR is addressing issue with deps installation when multiple pods are trying to install deps in the same time: https://splunk.atlassian.net/browse/ADDON-78266 To be reviewed together with: splunk/ta-automation-k8s-manifests#116 virtual environment is first build on github runner filesystem, site-packages are passed to aws s3, and finally downloaded directly to the empty venv on pods filesystem. ### Checklist - [x] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [x] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13140796010/job/36787923223 https://github.com/splunk/splunk-add-on-for-google-workspace/actions/runs/13153265349/job/36784656491 --------- Co-authored-by: kdoroszko-splunk <kdoroszko@splunk.com>
### Description Correlated PR: splunk/appinspect-cli-action#136 ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done - https://github.com/splunk/splunk-add-on-for-cisco-asa/actions/runs/13198034547 - https://github.com/splunk/splunk-add-on-for-salesforce/actions/runs/13197794456
### Description Reusable workflow fails in setup -> `modinput-test-prerequisites` ignores `ssh://` protocol in poetry.lock/pyproject.toml ``` [tool.poetry.group.modinput.dependencies] splunk_add_on_ucc_modinput_test = {git = "ssh://git@github.com/splunk/addonfactory-ucc-test.git", tag = "v0.2.0"} pytest-xdist = ">=3.5.0" ``` Example Job: https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13052937673/job/36605381881 ``` HangupException The remote server unexpectedly closed the connection. at /opt/hostedtoolcache/Python/3.7.17/x64/lib/python3.7/site-packages/dulwich/protocol.py:215 in read_pkt_line 211│ 212│ try: 213│ sizestr = read(4) 214│ if not sizestr: → 215│ raise HangupException 216│ size = int(sizestr, 16) 217│ if size == 0 or size == 1: # flush-pkt or delim-pkt 218│ if self.report_activity: 219│ self.report_activity(4, "read") The following error occurred when trying to handle this error: HangupException git@github.com: Permission denied (publickey). ``` ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [x] workflow errors/warnings reviewed and addressed ### Testing done PR using WF from branch `fix/setup_poetry_github` splunk/splunk-add-on-for-amazon-web-services#1401 Job https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13198332408/job/36845360655?pr=1401 --------- Co-authored-by: mkolasinski-splunk <mkolasinski@splunk.com>
### Description (PR description goes here) ### Checklist - [x] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [x] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description Limit test executions for scheduled runs to only latest Splunk version ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done https://github.com/splunk/test-addonfactory-repo/actions/runs/13200963135 --------- Co-authored-by: Dariusz Karas <dkaras@splunk.com>
### Description [ADDON-78360](https://splunk.atlassian.net/browse/ADDON-78360) [CI/CD] Add test label exit-first ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description Bump trufflehog from `3.85.0` to `v3.88.5` ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done https://github.com/splunk/splunk-add-on-for-cisco-meraki/actions/runs/13243642192/job/36964695234
### Description Remove code related to the requirement tests as those are not being used anymore. ### Checklist - [x] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releaes test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here) Co-authored-by: mkolasinski-splunk <mkolasinski@splunk.com>
### Description Fix missng for upgrade tests: https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13251113562/job/36989972917 ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
kdoroszko-splunk
approved these changes
Feb 11, 2025
🎉 This PR is included in version 4.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog:
Deps updates:
trufflesecurity/trufflehog to v3.88.5
k8s-manifests bump to v3.3.2 (upgrade tests, deps installation shift to GH runner)
appinspect cli action to v2.9 (Splunk appinspect 3.9.1)
Checklist
README.md
has been updated or is not requiredTesting done
https://github.com/splunk/splunk-add-on-for-salesforce/actions/runs/13244857657
https://github.com/splunk/splunk-add-on-for-crowdstrike-fdr/actions/runs/13244966818
https://github.com/splunk/splunk-add-on-for-palo-alto-networks/actions/runs/13244914436
https://github.com/splunk/splunk-add-on-for-jboss/actions/runs/13248334345
https://github.com/splunk/splunk-add-on-for-unix-and-linux/actions/runs/13244955484
https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/13244942793