Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cancel gh workflow #169

Merged
merged 15 commits into from
Jul 25, 2023
Merged

feat: cancel gh workflow #169

merged 15 commits into from
Jul 25, 2023

Conversation

mkolasinski-splunk
Copy link
Contributor

  • add concurrency to cancel running/pending workflows from same PR or pushed to same branch
  • replace condition for job execution always() with !cancelled()
  • reformatted multi-line strings with conditionals for job execution - tested that this is only solution for github to work properly with !cancelled() and other conditions
  • to all run-*-tests executed on argo added step Cancel workflow - now workflows sent by argo will be cancelled if github workflow is cancelled

Tested on:
https://github.com/splunk/splunk-add-on-for-google-workspace/actions/runs/5643680981/job/15289137706
https://github.com/splunk/splunk-add-on-for-cisco-meraki/actions/runs/5620072190/job/15289640068

@mkolasinski-splunk mkolasinski-splunk requested a review from a team as a code owner July 24, 2023 12:41
@mkolasinski-splunk mkolasinski-splunk force-pushed the feat/cancel-gh-workflow branch from 4ade83b to 3b2d206 Compare July 24, 2023 12:55
@mkolasinski-splunk mkolasinski-splunk merged commit 605e847 into main Jul 25, 2023
@mkolasinski-splunk mkolasinski-splunk deleted the feat/cancel-gh-workflow branch July 25, 2023 08:50
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemrys artemrys artemrys approved these changes

@mbruzda-splunk mbruzda-splunk Awaiting requested review from mbruzda-splunk mbruzda-splunk is a code owner automatically assigned from splunk/products-gdi-addons-adminrepo

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkolasinski-splunk @srv-rr-github-token @artemrys